Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Workspace owners to create Airlock requests and remove need for email #3904

Closed
SvenAelterman opened this issue Apr 11, 2024 · 1 comment · Fixed by #3988
Closed

Enable Workspace owners to create Airlock requests and remove need for email #3904

SvenAelterman opened this issue Apr 11, 2024 · 1 comment · Fixed by #3988
Assignees
@marrobi
Labels
airlock enhancement New feature or request storysize/L 1 week (2.5 days)
Milestone
Release 0.19.0

Comments

@SvenAelterman
Copy link
Collaborator

Describe the bug

When creating a new airlock request, the airlock seems to expect at least one member of the Workspace Researchers role with an email address assigned.

Besides the odd requirement for this (considering bug #3506), having only Workspace Owners should be supported too.

Steps to reproduce

  1. Create a workspace with airlock enabled.
  2. Assign Workspace Owner with an email address populated.
  3. Try to create an Airlock request.

Azure TRE release version (e.g. v0.14.0 or main): v0.16.0

Deployed Azure TRE components - click the (i) in the UI:

  • UI: 0.5.17
  • API: 0.16.9
@SvenAelterman SvenAelterman added bug Something isn't working airlock labels Apr 11, 2024
@marrobi
Copy link
Member

marrobi commented Apr 15, 2024

Agree, Workspace Owners should be supported, and the requirement for email made optional.

@marrobi marrobi moved this to Up Next in Azure TRE - Engineering Apr 15, 2024
@tim-allen-ck tim-allen-ck added feature and removed bug Something isn't working labels May 8, 2024
@tim-allen-ck tim-allen-ck changed the title Airlock request creation fails if no workspace researchers are defined Enable Workspace owners to create Airlock requests and remove need for email May 9, 2024
@tim-allen-ck tim-allen-ck self-assigned this May 23, 2024
@tim-allen-ck tim-allen-ck added the storysize/L 1 week (2.5 days) label May 23, 2024
@tim-allen-ck tim-allen-ck added this to the Release 0.19.0 milestone May 23, 2024
@marrobi marrobi added enhancement New feature or request and removed feature labels May 28, 2024
@tim-allen-ck tim-allen-ck removed their assignment Jun 6, 2024
@marrobi marrobi self-assigned this Jun 20, 2024
@marrobi marrobi moved this from Up Next to In Progress in Azure TRE - Engineering Jun 20, 2024
@tim-allen-ck tim-allen-ck mentioned this issue Jun 21, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure TRE - Engineering Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marrobi marrobi

Labels
airlock enhancement New feature or request storysize/L 1 week (2.5 days)
Projects
Azure TRE - Engineering
Archived in project
Milestone
Release 0.19.0
Development

Successfully merging a pull request may close this issue.

Enable Workspace owners to create Airlock requests and remove need for email marrobi/AzureTRE
3 participants
@marrobi @SvenAelterman @tim-allen-ck