Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public network access to the API app service is enabled #3986

Closed
jonnyry opened this issue Jun 20, 2024 · 0 comments · Fixed by #4022
Closed

Public network access to the API app service is enabled #3986

jonnyry opened this issue Jun 20, 2024 · 0 comments · Fixed by #4022
Labels
bug Something isn't working storysize/S a few hours or half day

Comments

@jonnyry
Copy link
Collaborator

jonnyry commented Jun 20, 2024

Public network access is enabled to the API app service, even though it has a private endpoint which the app gateway uses (https://microsoft.github.io/AzureTRE/v0.16.0/assets/architecture-azure.png)

public_network_access_enabled is not defined here (and therefore defaults to true):

AzureTRE/core/terraform/api-webapp.tf

Line 20 in 1ffb09b

resource "azurerm_linux_web_app" "api" {

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working storysize/S a few hours or half day
Projects
None yet
Milestone
No milestone
2 participants
@jonnyry @tim-allen-ck