AppServiceFileAuditLogs diagnostic setting - remove?

[jonnyry]

The AppServiceFileAuditLogs diagnostic setting is enabled for App Services:

AzureTRE/core/terraform/locals.tf

Lines 8 to 11 in 43eb846

	api_diagnostic_categories_enabled = [
	"AppServiceHTTPLogs", "AppServiceConsoleLogs", "AppServiceAppLogs", "AppServiceFileAuditLogs",
	"AppServiceAuditLogs", "AppServiceIPSecAuditLogs", "AppServicePlatformLogs", "AppServiceAntivirusScanAuditLogs"
	]

It is a Premium SKU only setting, so you need a Premium App Service plan for it to be enabled.

There are zero logs for a 3 month time range in our core log analytics workspace, so there appears to be little benefit in having it enabled.

Unless there was an specific intention behind this setting, I propose it is removed, in order to remove the requirement on Premium SKU App Service plans. This can also be applied to the Guacamole service and other App Service instances.