-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Automated Backup Management for Shared VM Storage in Azure TRE #4362
Comments
@james-annages that sounds great and is something the project would greatly benefit from. Is it something you are intending to work on and could contribute a PR? |
@marrobi I am working on the the external function for my org atm but would be happy to throw some time at smashing my head in to that brick wall (I jest). I will have a look at mocking up something and see what happens. I'm thinking the best best would be to add it in to the workspace terraform code as a check/if call? Open to other suggestions? |
I think need to break it down into stages, happy to help do that. I there is a solid design its much easier to implement. One question I have is does each workspace have its own backup vault. Not sure if there would be any benefits in that? We have some work that might be done soon allowing different workspaces to sit in different subscriptions. I'm not sure if we can backup to a vault in another subscription. |
Nope, see note on this page: https://learn.microsoft.com/en-us/azure/backup/backup-azure-move-recovery-services-vault#use-azure-portal-to-move-recovery-services-vault-to-a-different-subscription
So think this would need a vault in the workspace, in a way this simplifies things as its a flag in the workspace. Shared services/core would have to be considered independently. Thoughts? |
Something like - https://charbelnemnom.com/auto-protect-azure-file-shares-in-azure-backup/ Albeit we don't have much PowerShell in the project (mostly az cli). |
So looking at the project board just seen the mulitiple subs idea.
In addition it might be worth also having a shared serivise if you are only wanting to backup file shares but need to investigate that further. |
I think keep it in the workspace, rather than a service, then its an explicit opt in/out, and less bundles to manage. You ok to give this a go? Happy to support as needed. Thank you! |
Happy to give this a kick and see what happens. May need some poking to get other bits to work correctly for auto registration of resources vms, shares etc. |
some progress. currently doing a test deployment (going to leave it going while i go to bed) if it works next steps will be to add to the DB for the policy id's for the vm backup and the vault name. |
That's great, if you have some code and want to open draft PR, feel free, we can try iterate from there. Happy to help on the UI/API side. |
PR opened. I was thinking of as a base just try and get a report in to a tab for backups. What do people think? |
Is your feature request related to a problem? Please describe.
Currently, we have a need to back up data stored in Shared VM storage within Azure TRE workspaces. At the moment, we rely on an external Azure Function that periodically discovers new file shares and manually adds them to an Azure Recovery Services Vault for backup. This approach is not scalable and lacks built-in visibility into backup status.
Describe the solution you'd like
A shared service that can be deployed within Azure TRE to automate the deployment and configuration of Azure Recovery Vaults for workspace storage, ensuring all shared VM storage is backed up efficiently.
Key Features:
Automated Azure Recovery Vault Deployment
Per-Workspace Backup Configuration
Backup Retention & Storage Options
Backup Monitoring & Status Dashboard
Describe alternatives you've considered
Currently, we have deployed an external Azure Function that runs on a schedule to scan for new shares and manually add them to an Azure Recovery Services Vault. This method is inefficient and lacks visibility into backup status, retention settings, and failure monitoring.
Additional Context
Implementing this feature as a shared service would provide a native, integrated solution within Azure TRE, eliminating the need for external automation and providing a centralized view of backup operations.
The text was updated successfully, but these errors were encountered: