Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Sample 11. qnamaker uses deprecated generateAnswers() #1021

Closed
Zerryth opened this issue Dec 5, 2018 · 1 comment
Closed

JS Sample 11. qnamaker uses deprecated generateAnswers() #1021

Zerryth opened this issue Dec 5, 2018 · 1 comment
Assignees
@Zerryth
Labels
P1 Painful if we don't fix, won't block releasing

Comments

@Zerryth
Copy link
Contributor

Zerryth commented Dec 5, 2018

Sample information

  1. Sample type: samples
  2. Sample language: node
  3. Sample name: 11.qnamaker

Describe the bug

QnAMaker references sample 11.qnamaker to illustrate how to query an answer from the QnA Maker service.

As of PR microsoft/botbuilder-js#683 generateAnswers() has been deprecated, however 11.qnamaker uses it as the method to query answers.

Instead, new method getAnswers() should be used to query QnA service.

Reference to this sample has been removed from the QnAMaker class documentation.
Can add link back, once query method has been updated

[bug]
@sgellock sgellock added Approved P1 Painful if we don't fix, won't block releasing labels Dec 6, 2018
@sgellock
Copy link
Member

sgellock commented Dec 6, 2018

@Zerryth can you issue a PR on the sample please? Thanks

@Zerryth Zerryth mentioned this issue Dec 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zerryth Zerryth

Labels
P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgellock @Zerryth