Some changes are needed to 21.corebot-app-insights

[WashingtonKayaker]

In reviewing the javascript_nodejs version of sample 21.corebot-app-insights, I've noticed a few issues that I think need to be addressed:

• Need to incorporate the changes made in PR1964 Override ActivityHandler.run() instead of using ActivityHandler.onDialog() to save state changes. This impacts dialogBot.js.

  This is the current code:

   this.onDialog(async (context, next) => {
   	// Save any state changes. The load happened during the execution of the Dialog.
   	await this.conversationState.saveChanges(context, false);
   	await this.userState.saveChanges(context, false);
  
   	// By calling next() you ensure that the next BotHandler is run.
   	await next();
   });

  This is how it should be coded:

   async run(context) {
   	await super.run(context);
  
   	// Save any state changes. The load happened during the execution of the Dialog.
   	await this.conversationState.saveChanges(context, false);
   	await this.userState.saveChanges(context, false);
   }

• Need to incorporate the changes made in PR1868: add send trace calls and fix multiling.

  The following code needs to be added to index.js probably starting on line 48…

   // Send a trace activity, which will be displayed in Bot Framework Emulator
   await context.sendTraceActivity(
   	'OnTurnError Trace',
   	`${ error }`,
   	'https://www.botframework.com/schemas/error',
   	'TurnError'
   );

• A console.log line is missing, see line 88 in index.js

   console.log('\nTo talk to your bot, open the emulator select "Open Bot"');

• Missing braces in mainDialog.js. These were added to CoreBot the end of October. See line 82, 98, 100, 105, 107, 111

• CancelAndHelpDialog.js: Same thing – missing braces in switch statement. See line 26 etc. Compare with CoreBot line 26.