Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new dialog via the "Begin a new dialog" property pane does not set the dialog property #1631

Closed
2 of 7 tasks
benbrown opened this issue Nov 21, 2019 · 2 comments
Closed
2 of 7 tasks
Labels
Type: Bug Something isn't working

Comments

@benbrown
Copy link
Contributor

benbrown commented Nov 21, 2019

Describe the bug

If you choose "Create a new dialog" from the "Begin dialog" property pane, it does create a dialog, but does NOT set the property as expected to that new dialog.

In addition, an INVALID ACTION is written to the new child dialog's trigger list that includes a circular reference (the newly created child dialog will contain a reference to itself), and this causes the 'Restart bot' process to fail.

Screen Shot 2019-11-21 at 12 59 32 PM

This is an example of the invalid JSON that is added to the trigger list:

    {
      "actions": [
        {
          "$type": "Microsoft.BeginDialog",
          "$designer": {
            "id": "445290",
            "name": "Begin a new dialog"
          },
          "dialog": "doNewChildDialog"
        }
      ]
    }

Version

e47d8ec

Browser

What browser are you using?

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

What operating system are you using?

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Add a "Begin a new dialog" action
  2. In the dropdown for dialog, select "Create a new dialog"
  3. give name/description of new dialog
  4. navigate back to parent dialog - notice the dialog property is blank.

... also

  1. Notice that the new child dialog has an invalid and INVISIBLE circular reference to itself in the .dialog file. This dialog is broken and cannot be referenced without being manually fixed outside of Composer.

Expected behavior

Give a clear and concise description of what you expected to happen.

The name of the newly created dialog will be set into the property field where the "create new dialog" option was initially selected

Screenshots

If applicable, add screenshots/gif/video to help explain your problem.

Additional context

Add any other context about the problem here.

@benbrown benbrown added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Nov 21, 2019
@benbrown
Copy link
Contributor Author

It would appear that the dialog property that belongs in the parent dialog's call to BeginDialog is ending up in the new child dialog's trigger list somehow.

@a-b-r-o-w-n
Copy link
Contributor

duplicate of #1144 which is in development now.

@a-b-r-o-w-n a-b-r-o-w-n removed the Needs-triage A new issue that require triage label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants