Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bugs in Composer samples #1763

Closed
zxyanliu opened this issue Dec 11, 2019 · 1 comment
Closed

Small bugs in Composer samples #1763

zxyanliu opened this issue Dec 11, 2019 · 1 comment
Assignees
@alanlong9278 @luhan2017
Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working

Comments

@zxyanliu
Copy link
Contributor

Here are a few bugs I found in current Composer samples.

1. ControllingConveresationFlowSample

Bug: The properties panel of Dialog cancelled event shows "Unsupported field schema for field Main#.trigger".

image

2. AskingQuestionsSample

Bug: In the help LG template, the number should be 01-07 instead of 01-04

image

3. InterruptionSample

Bug: the LG templates with suggestions do not work as expected.

- Hello, I'm the interruption demo bot! \n \[Suggestions=Get started | Reset profile]

Tested in Emulator:
image

Expected behavior:
Should have real suggested options displayed as buttons.

4. RespondingWithTextSample

Bug: Choose 1. SimpleText and 3. TextWithLG output same result because SimpleText references TextWithLG template. What does TextWithLG mean? Does it mean LGComposition? It is confusing.

image

Proposed solution:
Delete TextWithLG template and define SimpleText template as follows:

# SimpleText
- Hi, this is simple text
- Hey, this is simple text
- Hello, this is simple text

This definition is to show that any defined simple text in this template will be picked by random.
@zxyanliu zxyanliu added the Needs-triage A new issue that require triage label Dec 11, 2019
@hibrenda hibrenda added the Type: Bug Something isn't working label Dec 11, 2019
@hibrenda hibrenda added R8 Release 8 - March 16th, 2020 and removed Needs-triage A new issue that require triage labels Dec 12, 2019
@luhan2017 luhan2017 mentioned this issue Dec 16, 2019
Merged
9 tasks
@cwhitten
Copy link
Member

addressed in #1735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanlong9278 alanlong9278

@luhan2017 luhan2017

Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @alanlong9278 @luhan2017 @zxyanliu @hibrenda