Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linting & Validation] some diagnostics do not get reported in form due to path format #1972

Closed
a-b-r-o-w-n opened this issue Feb 10, 2020 · 2 comments
Closed

[Linting & Validation] some diagnostics do not get reported in form due to path format #1972

a-b-r-o-w-n opened this issue Feb 10, 2020 · 2 comments
Assignees
@alanlong9278 @lei9444
Labels
Type: Bug Something isn't working

Comments

@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Feb 10, 2020 •
edited
Loading

Describe the bug

Fields in deep paths do not show errors in the form.

Version

2268545

To Reproduce

Steps to reproduce the behavior:

  1. Open up the Dialog Actions sample.
  2. Go to the SwitchConditon dialog.
  3. In the SwitchConditon action, add an action that includes a condition
  4. Add an invalid condition, ex. foo = bar
  5. Notice the error appears in the notifications page, but not in the form.

Expected behavior

Error should also appear in the form.

Screenshots

image

Additional context

LG errors still show in the form.
@a-b-r-o-w-n a-b-r-o-w-n added the Needs-triage A new issue that require triage label Feb 10, 2020
@hibrenda hibrenda added Type: Bug Something isn't working and removed Needs-triage A new issue that require triage labels Feb 11, 2020
@alanlong9278 alanlong9278 assigned lei9444 and unassigned alanlong9278 Feb 11, 2020
@lei9444 lei9444 mentioned this issue Feb 12, 2020
Merged
@a-b-r-o-w-n
Copy link
Contributor Author

This has not been fixed following the repro steps in b2501bf

@a-b-r-o-w-n a-b-r-o-w-n reopened this Feb 18, 2020
@lei9444 lei9444 mentioned this issue Feb 19, 2020
Merged
@cwhitten
Copy link
Member

addressed via #2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanlong9278 alanlong9278

@lei9444 lei9444

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cwhitten @a-b-r-o-w-n @alanlong9278 @lei9444 @hibrenda