Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LuEditorWidget to function component #2138

Closed
cwhitten opened this issue Mar 1, 2020 · 5 comments
Closed

Refactor LuEditorWidget to function component #2138

cwhitten opened this issue Mar 1, 2020 · 5 comments
Assignees
@alanlong9278
Labels
P2 Nice to have R11 Release 11 - November 15th, 2020

Comments

@cwhitten
Copy link
Member

cwhitten commented Mar 1, 2020

Refer to LgEditorWidget.

Goals: Convert to function components, create/reference hooks to hoist shared complexity (local state, change management, sync) between LgEditorWidget and LuEditorWidget.
@cwhitten cwhitten added the R10 Release 10 - August 17th, 2020 label Mar 1, 2020
@cwhitten cwhitten mentioned this issue Mar 1, 2020
Merged
5 tasks
@yeze322

This comment has been minimized.

Sign in to view
@yeze322

This comment has been minimized.

Sign in to view
@yeze322

This comment has been minimized.

Sign in to view
@alanlong9278 alanlong9278 self-assigned this Mar 4, 2020
@yeze322 yeze322 added the P2 Nice to have label Mar 17, 2020
@cwhitten cwhitten added R11 Release 11 - November 15th, 2020 and removed R10 Release 10 - August 17th, 2020 labels Jul 14, 2020
@yeze322
Copy link
Contributor

yeze322 commented Aug 18, 2020

This issue is outdated, the code has been updated several times. Can be closed.

@yeze322 yeze322 closed this as completed Aug 18, 2020
@yeze322
Copy link
Contributor

yeze322 commented Aug 18, 2020

Hide my oudated comments about implementation details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanlong9278 alanlong9278

Labels
P2 Nice to have R11 Release 11 - November 15th, 2020
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cwhitten @alanlong9278 @yeze322