Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Editor flickering issue in nested flow when deleting / inserting #2175

Closed
7 tasks
yeze322 opened this issue Mar 5, 2020 · 4 comments
Closed
7 tasks
Labels
Area: Visual editor R9 Release 9 - May 15th, 2020

Comments

@yeze322
Copy link
Contributor

yeze322 commented Mar 5, 2020

Describe the bug

After inserting / deleting an action under a nested action type (IfCondition, SwitchCondition, Foreach), Visual Editor will be rendered twice (flickering).

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create a IfCondition node
  2. Create a nested IfCondition node under the true branch
  3. Insert some nodes / delete some nodes under the nested true branch

Expected behavior

Screenshots

Additional context

@yeze322 yeze322 changed the title Visual Editor flickering issue in nested flow Visual Editor flickering issue in nested flow when deleting / inserting Mar 5, 2020
@yeze322
Copy link
Contributor Author

yeze322 commented Mar 5, 2020

This issue is introduced by a latest feature PR #2005 .
In that PR, visual editor storaged all nodes' sizes into a global cache to avoid frequently re-computation of element sizes. It did help us having a stable layout.

However, with that cache mechanism, when user deleting / inserting a leaf node, parent nodes' sizes will still be loaded from cache instead of recalculating the size, it makes the layouter consumes an outdated size, then deletion/insertion of any nested node will cause flickering issue.

@yeze322
Copy link
Contributor Author

yeze322 commented Mar 5, 2020

The solution is making some improvements on layout cache management:
image

@yeze322
Copy link
Contributor Author

yeze322 commented Mar 5, 2020

The solution is making some improvements on layout cache management:

Addressed in #2176.
Fix it just as I described

@hibrenda hibrenda added the R9 Release 9 - May 15th, 2020 label Mar 16, 2020
@cwhitten
Copy link
Member

addressed via #2176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Visual editor R9 Release 9 - May 15th, 2020
Projects
None yet
Development

No branches or pull requests

3 participants