Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on the LU error notification does not show the LU error content #2533

Closed
7 tasks
bobokids opened this issue Apr 7, 2020 · 3 comments
Closed
7 tasks
Assignees
Labels
R9 Release 9 - May 15th, 2020 skill-reported Type: Bug Something isn't working

Comments

@bobokids
Copy link

bobokids commented Apr 7, 2020

Describe the bug

. Add a line of LU data with error to the LU trigger phrase
. Notice that an error icon showing besides the "Start Bot" button
. Click the button to get the detail LU error notifications
. Click each error notification
. Composer jump to the Lu All-up view

Expect:
Composer shows the LU data with error I added.

Result:
the error data didn't show up in the view.

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

. error data added
image
. error indicator
image
. error notifications
image
. when click the error notification item, composer jump to all-up view, and all data are correct there.
image

Additional context

@bobokids bobokids added Type: Bug Something isn't working Needs-triage A new issue that require triage skill-reported labels Apr 7, 2020
@boydc2014 boydc2014 removed the Needs-triage A new issue that require triage label Apr 7, 2020
@hibrenda hibrenda added the R9 Release 9 - May 15th, 2020 label Apr 7, 2020
@boydc2014
Copy link
Contributor

We've seen some back and force on the notification page behavior, let's meet to clarity the design and solve any potential design issues. @liweitian @lei9444 @zhixzhan

@zhixzhan
Copy link
Contributor

zhixzhan commented Apr 8, 2020

I committed a fix, now error can navigate to all up view editor.

ps:
I remember previous a logic is if error happen on a dialog used intent, click will navigate to form editor. but now mostly will not, almost all error navigate to all up view.
After some debug, I found the reason is luParser can't parse every error intent, meanwhile our find error intent in dialogPath rely on parse results. That caused failed to calculate dialogPath, then failed to navigate to form editor.

@cwhitten
Copy link
Member

cwhitten commented Apr 9, 2020

addressed via #2561

@cwhitten cwhitten closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R9 Release 9 - May 15th, 2020 skill-reported Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants