Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code hygiene: Remove old _underscore prefix for “private” methods #3484

Closed
GeoffCoxMSFT opened this issue Jun 24, 2020 · 2 comments · Fixed by #3496
Closed

Code hygiene: Remove old _underscore prefix for “private” methods #3484

GeoffCoxMSFT opened this issue Jun 24, 2020 · 2 comments · Fixed by #3496
Assignees
@beyackle
Labels
Type: Engineering

Comments

@GeoffCoxMSFT
Copy link
Member

See if eslint can detect and prevent. Update to to remove _ prefix from function scoped const methods.
@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Jun 24, 2020
@beyackle beyackle self-assigned this Jun 24, 2020
@beyackle
Copy link
Contributor

I'll take this on - it fits well with the code-hygiene push I'd been working on.

@GeoffCoxMSFT GeoffCoxMSFT removed their assignment Jun 24, 2020
@GeoffCoxMSFT
Copy link
Member Author

Sounds good - all yours.

@beyackle beyackle mentioned this issue Jun 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beyackle beyackle

Labels
Type: Engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: add rule and remove dangling underscores microsoft/BotFramework-Composer
2 participants
@GeoffCoxMSFT @beyackle