Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support locale at StartConversation #292

Closed
timenick opened this issue Jul 8, 2020 · 1 comment · Fixed by #293
Closed

Support locale at StartConversation #292

timenick opened this issue Jul 8, 2020 · 1 comment · Fixed by #293
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@timenick
Copy link
Contributor

timenick commented Jul 8, 2020

##Issue
Original issue: microsoft/botframework-obi#75

This issue tracks a frequently requested feature to allow a user locale when starting new conversations. The user locale is needed so that bots can send a properly localized Greeting Message to users.

##Proposed change
DirectLineJS - update the protocol to support locale and userId

Tracking WebChat issue: microsoft/BotFramework-WebChat#3296

@compulim compulim added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. labels Jul 8, 2020
@compulim
Copy link
Collaborator

compulim commented Jul 8, 2020

@youyu16 I saw you were assigned to this issue. So please let me know if the assignment is wrong so we can re-assign to someone else.

The goal should be:

  new DirectLine({
+   locale: 'en-US',
    token
  })

@timenick timenick self-assigned this Jul 10, 2020
@timenick timenick changed the title Support locale and userId at StartConversation Support locale at StartConversation Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants