Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a Save command for the bot file configuration (don't save without asking) #1277

Closed
pkirch opened this issue Jan 30, 2019 · 7 comments
Labels
Design Design Team issue

Comments

@pkirch
Copy link

pkirch commented Jan 30, 2019

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe.
My bot file settings were gone when I changed them in the Bot Framework Emulator.

Describe the solution you'd like
I changed the endpoint settings in the Bot Framework Emulator to test the same bot at another endpoint. I did not know that it would save it directly to my bot file and overwrite my previous settings.

Describe alternatives you've considered
When I change the settings in the Bot Framework Emulator I would like to have a save command to save my settings to the bot file. As long I have not explicitly saved my settings in the Bot Framework Emulator I do not want my bot file changed.

Additional context
I mean the settings page when I right-click the an endpoint (e.g. development or production) and click on "Edit configuration".

[enhancement]

@tonyanziano
Copy link
Contributor

Hi @pkirch ,

This is intended behavior. When you select "Edit Configuration" for an endpoint, and change the configuration, it will save the updated version.

If you want to test a new endpoint configuration without modifying an existing one, then you want to hit the "+" button to add a new configuration. This will still modify your bot file by adding a new endpoint, but it will leave your old ones intact.

image

image

@tonyanziano
Copy link
Contributor

tonyanziano commented Jan 31, 2019

Some further clarification:

The emulator exposes a lot of the bot file configuration through the bot explorer pane via the Endpoint and Services collapsible regions. Anything you see in those fields is a direct representation of your bot file in real time. This means that any modifications you make to these fields will be reflected in your bot file on disk immediately.

There is no explicit save functionality because of this. You can always add a service / endpoint to test, and remove it if you no longer want it.

@pkirch
Copy link
Author

pkirch commented Jan 31, 2019

I understand your intended behavior. IMO that's different to other applications I use like Visual Studio where you have to explicitly save settings even when they are made in a settings dialog.

Maybe I can suggest that you rename the "Submit" button from the settings dialog into a "Save" button.

@navzam
Copy link
Member

navzam commented Feb 1, 2019

This is closely related to #1172. Even if it's by design for the emulator to edit your .bot files, that isn't clear. It's very easy to accidentally delete your endpoints/services.

@tonyanziano tonyanziano reopened this Feb 1, 2019
@tonyanziano
Copy link
Contributor

Adding @mewa1024 for design consideration.

@mewa1024
Copy link

mewa1024 commented Feb 4, 2019

Changing the button from "Submit" to "Save" makes sense to me.

@tonyanziano
Copy link
Contributor

The text have been changed to 'Save' in #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design Team issue
Projects
None yet
Development

No branches or pull requests

4 participants