Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettier: double quotes in sample code #2131

Closed
compulim opened this issue Jun 28, 2019 · 0 comments · Fixed by #2393
Closed

Prettier: double quotes in sample code #2131

compulim opened this issue Jun 28, 2019 · 0 comments · Fixed by #2393
Assignees
@tdurnford
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner

Comments

@compulim
Copy link
Contributor

Describe the bug

Looks like prettier is cleaning up our sample code using another styles that prefer double quotes than single quote.

@corinagum has more context in this issue.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jun 28, 2019
@compulim compulim mentioned this issue Jun 28, 2019
Merged
@corinagum corinagum self-assigned this Jun 28, 2019
@corinagum corinagum added Triage-E front-burner backlog Out of scope for the current iteration but it will be evaluated in a future release. and removed Pending labels Jul 1, 2019
@corinagum corinagum added 4.6 and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jul 10, 2019
@corinagum corinagum assigned tdurnford and unassigned corinagum Aug 16, 2019
@tdurnford tdurnford mentioned this issue Sep 11, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdurnford tdurnford

Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Prettier to samples tdurnford/BotFramework-WebChat
3 participants
@compulim @corinagum @tdurnford