Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong propTypes on AdaptiveCardRenderer.tapAction #2250

Closed
compulim opened this issue Jul 31, 2019 · 0 comments · Fixed by #2253
Closed

Wrong propTypes on AdaptiveCardRenderer.tapAction #2250

compulim opened this issue Jul 31, 2019 · 0 comments · Fixed by #2253
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Jul 31, 2019

Version

master

Describe the bug

Prop types on AdaptiveCardRenderer.js is wrong for tapAction, it should be:

  tapAction: PropTypes.shape({
    type: PropTypes.string.isRequired,
    value: PropTypes.string
  })

To Reproduce

Steps to reproduce the behavior:

  1. Go to playground
  2. Type receiptcard
  3. Open F12 developer tool

Expected behavior

Expect no warnings.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jul 31, 2019
@compulim compulim mentioned this issue Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant