Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better visual feedback on button click. #2401

Closed
matthidinger opened this issue Sep 16, 2019 · 5 comments
Closed

Better visual feedback on button click. #2401

matthidinger opened this issue Sep 16, 2019 · 5 comments
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. external-adaptive-cards feature-request Azure report label needs-design-input UX/UI design item

Comments

@matthidinger
Copy link
Member

@vijaysaimutyala commented on Fri Aug 30 2019

This is for the card using the WebChat renderer. The earlier version of the Adaptive cards used give a nice visual feedback to the user whether the button was clicked or not. But with the latest updates, the feedback is no longer present. It just shows a outline around the button in accent color which is not very helpful.

Old Adaptive Cards

Old-Adaptive-Button-Feedback

New Adaptive Cards
New Adaptive Card

Users are not able to understand whether they've clicked the button or not. Sometimes when the response from the bot needs some time to process and respond, the user without the help of feedback is clicking the button again before the response from bot appears. Any suggestions on this would be helpful.


@matthidinger commented on Mon Sep 16 2019

@compulim @corinagum can you folks take a look at this?

@corinagum corinagum added customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Sep 16, 2019
@corinagum
Copy link
Contributor

corinagum commented Sep 16, 2019

@matthidinger thanks for the transfer.

Rather than just Adaptive Cards, I would say this is a potential improvement we can make to the entire Web Chat app. We intentionally removed the pointer cursor from buttons in #1819 a few months ago, but that doesn't mean we can't improve the :active pseudo class UX throughout the project.

potential design questions:

  1. Should this take the accent color from styleOptions? or
  2. Should this be a new style option like buttonActiveBgColor, buttonActiveTextColor, buttonActiveOutline etc.
  3. Do we allow differentiation between the styling of Adaptive Cards buttons and other buttons?

@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. needs-design-input UX/UI design item front-burner Enhancement customer-replied-to Required for internal reporting. Do not delete. labels Sep 16, 2019
@vijaysaimutyala
Copy link

@matthidinger @corinagum Do you think there's some quick hack that could bring back the visualization ?

@corinagum
Copy link
Contributor

corinagum commented Sep 20, 2019

@vijaysaimutyala you can consider adding to your web page's CSS specification to the button you want to modify. To do this you would need to trace the DOM to the button, brief example below:
(hacky workaround)

.main > div > div > ... .ac-pushButton &:active {
    background-color: #etcetc
}

Then once Web Chat's changes are in you can just delete this CSS. :)

@vijaysaimutyala
Copy link

Thanks @corinagum

@corinagum
Copy link
Contributor

The content of the card belongs to adaptive cards team, so it would be better to keep the styling responsibility on that of the Adaptive Card templating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. external-adaptive-cards feature-request Azure report label needs-design-input UX/UI design item
Projects
None yet
Development

No branches or pull requests

3 participants