You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems core-js is loaded incorrectly. This is causing sagas/effects/forkPut.js to fail after Webpack in IE11. This bug is introduced when we bump core-js@2 to core-js@3 in PR #2195, because core-js@3 changed the import signature.
Instead of loading using import 'core-js/modules/es.symbol', we should load it using import 'core-js/features/symbol'.
I believe when we load from /features/ instead of /modules/, these features are aware of each other. For example, "symbol" is aware of "array.iterator" and complement each other. But when we are loading from /modules/, they do not aware of each other.
To Reproduce
Steps to reproduce the behavior:
Create a create-react-app
No need to install Web Chat, we are just proving the polyfill is loaded incorrectly
Copy the polyfill code from index-es5.ts to the app
Version
master
Describe the bug
It seems
core-js
is loaded incorrectly. This is causingsagas/effects/forkPut.js
to fail after Webpack in IE11. This bug is introduced when we bumpcore-js@2
tocore-js@3
in PR #2195, becausecore-js@3
changed the import signature.Instead of loading using
import 'core-js/modules/es.symbol'
, we should load it usingimport 'core-js/features/symbol'
.I believe when we load from
/features/
instead of/modules/
, these features are aware of each other. For example, "symbol" is aware of "array.iterator" and complement each other. But when we are loading from/modules/
, they do not aware of each other.To Reproduce
Steps to reproduce the behavior:
create-react-app
index-es5.ts
to the appcore-js
from https://github.com/microsoft/BotFramework-WebChat/blob/master/packages/bundle/src/index-es5.ts#L8npm run build
new Array()[Symbol.iterator]
Expected behavior
After running the code, it should return a function, polyfilled by
core-js
.Instead, it is returning
undefined
.Additional context
[Bug]
The text was updated successfully, but these errors were encountered: