Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11: Cannot load Array[Symbol.iterator] polyfill #2513

Closed
compulim opened this issue Oct 30, 2019 · 0 comments · Fixed by #2514
Closed

IE11: Cannot load Array[Symbol.iterator] polyfill #2513

compulim opened this issue Oct 30, 2019 · 0 comments · Fixed by #2514
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Oct 30, 2019

Version

master

Describe the bug

It seems core-js is loaded incorrectly. This is causing sagas/effects/forkPut.js to fail after Webpack in IE11. This bug is introduced when we bump core-js@2 to core-js@3 in PR #2195, because core-js@3 changed the import signature.

Instead of loading using import 'core-js/modules/es.symbol', we should load it using import 'core-js/features/symbol'.

I believe when we load from /features/ instead of /modules/, these features are aware of each other. For example, "symbol" is aware of "array.iterator" and complement each other. But when we are loading from /modules/, they do not aware of each other.

To Reproduce

Steps to reproduce the behavior:

  1. Create a create-react-app
    • No need to install Web Chat, we are just proving the polyfill is loaded incorrectly
  2. Copy the polyfill code from index-es5.ts to the app
  3. Run npm run build
    • CRA development build do not work with IE11, it only works with production build
  4. Host the app
  5. On IE11, browse to http://localhost:3000/
  6. In the console, run new Array()[Symbol.iterator]

Expected behavior

After running the code, it should return a function, polyfilled by core-js.

Instead, it is returning undefined.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Oct 30, 2019
@compulim compulim mentioned this issue Oct 30, 2019
1 task
@compulim compulim removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Oct 30, 2019
@compulim compulim mentioned this issue Oct 31, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant