Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron #2886

Closed
compulim opened this issue Feb 6, 2020 · 1 comment · Fixed by #3079
Closed

Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron #2886

compulim opened this issue Feb 6, 2020 · 1 comment · Fixed by #3079
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Feb 6, 2020 •
edited
Loading

Please also bump Jest

Version

4.7.1

Describe the bug

Direct Line Speech failed to load in Electron due to a bug in Cognitive Services Speech SDK. It is fixed in 1.9.1.

microsoft/cognitive-services-speech-sdk-js#138
microsoft/cognitive-services-speech-sdk-js#126

Steps to reproduce

  1. Put Web Chat inside an Electron app (Chrome 69)
  2. Use Direct Line Speech to connect to bot
  3. Start recognizing

Expected behavior

It should start recognizing and sending WAV to the Speech servers. Instead, it just say "Starting..." and hang from there.

Additional context

Tagging @tonyanziano.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Feb 6, 2020
@corinagum corinagum changed the title Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron + bump Jest Feb 6, 2020
@corinagum corinagum changed the title Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron + bump Jest Bump Cognitive Services SDK to 1.9.1 due to a bug in Electron Mar 6, 2020
@corinagum corinagum mentioned this issue Mar 6, 2020
Closed
@cwhitten cwhitten added the R9 label Mar 9, 2020
@corinagum corinagum removed the Pending label Apr 3, 2020
@corinagum
Copy link
Contributor

Dupe of #3079?

@compulim compulim mentioned this issue Apr 21, 2020
Merged
1 task
@compulim compulim mentioned this issue May 15, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Selectable audio input device compulim/BotFramework-WebChat
3 participants
@cwhitten @compulim @corinagum