Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download file hyperlink should have "download" attribute #2923

Closed
compulim opened this issue Feb 19, 2020 · 2 comments · Fixed by #2963
Closed

Download file hyperlink should have "download" attribute #2923

compulim opened this issue Feb 19, 2020 · 2 comments · Fixed by #2963

Comments

@compulim
Copy link
Contributor

compulim commented Feb 19, 2020 •
edited
Loading

Feature Request

When downloading a file, we could use the activity.attachment[].name as the filename.

<a href="https://.../downloadFile?id=12345" download="helloworld.txt">

image

[Enhancement]
@compulim
Copy link
Contributor Author

Planning for R9.

@compulim
Copy link
Contributor Author

compulim commented Feb 28, 2020 •
edited
Loading

image

This feature only works for blob: or data:, or same origin URLs.

@compulim compulim mentioned this issue Feb 28, 2020
Merged
1 task
@compulim compulim mentioned this issue Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add download attribute to file attachment link compulim/BotFramework-WebChat
1 participant
@compulim