Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card action should open in new window with "noopener" and "noreferrer" #3223

Closed
compulim opened this issue Jun 8, 2020 · 0 comments · Fixed by #3224
Closed

Card action should open in new window with "noopener" and "noreferrer" #3223

compulim opened this issue Jun 8, 2020 · 0 comments · Fixed by #3224
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Jun 8, 2020

Version

master

Describe the bug

When click on a card to execute the openUrl card action, the URL must be open on a new tab with noopener and noreferrer set.

When #2892 is being implemented, it should tell Web Chat the windowName and windowFeatures.

Steps to reproduce

  1. Type card bingsports
  2. Click on the Seahawk logo

Expected behavior

It should open the URL in a new tab without access to window.opener, and the HTTP request should not have Referrer set.

Additional context

[Bug]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "noopener noreferrer" to card action compulim/BotFramework-WebChat
1 participant
@compulim