-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatched event, postBack, or messageBack + activityMiddleware causes fatal error #3434
Comments
@stevkan I believe this is due to a breaking change in Web Chat v4.10. Take a look the Breaking Changes in the Change Log for more details. @compulim Can you please weigh in. |
@tdurnford, thanks for the info. That did seem to fix it. Originally, I had a different implementation that, with v.4.10.0, was failing. I went to the samples and updated according to those which, as you can see, still wasn't working. Late on a Friday, I hadn't thought to check the change log. |
I'm going to reopen this since the sample is still broken. |
@tdurnford, good call on re-opening. Just tested the sample referenced above, again, and yes it is still broken. The readme shows the below code which, presumably, MockBot still uses as it also breaks when calling the hero card and clicking the const activityMiddleware = () => next => card => {
return children => (
<div className={card.activity.from.role === 'user' ? 'highlightedActivity--user' : 'highlightedActivity--bot'} >
{next(card)(children)}
</div>
);
}; |
Needs prioritization |
Screenshots
Version
CDN: v4.10.0
Describe the bug
Error occurs when
store.dispatch()
is used to send aSEND_EVENT
,SEND_POST_BACK
, orSEND_MESSAGE_BACK
activity andactivityMiddleware
is also utilized.Steps to reproduce
Expected behavior
No error should occur with dispatch and activityMiddleware functioning, as expected.
[Bug]
The text was updated successfully, but these errors were encountered: