Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDLC security tool PoliCheck #3514

Closed
corinagum opened this issue Oct 1, 2020 · 1 comment · Fixed by #3545
Closed

SDLC security tool PoliCheck #3514

corinagum opened this issue Oct 1, 2020 · 1 comment · Fixed by #3545
Assignees
@corinagum
Labels
area-docs Documentation required Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Milestone
R11

Comments

@corinagum
Copy link
Contributor

corinagum commented Oct 1, 2020 •
edited
Loading

[INFO] adding needs-team-attention label to discuss punting other R11 issues in favor of this one.

I haven't delved into the scope of the work I need to do here, but here are William's notes:

One of the SDLC security tool "PoliCheck"[url redacted] flagged the language we used in our code comments are not appropriate. As is responsible for docs, could you please look at the PoliCheck artifact in this pipeline, download the XML file, and fix those issues? As we operate largely outside of Azure DevOps, this is manual work and we need to look at the XML files from time to time. Maybe during our release cycle, or slightly more frequently, as those PoliCheck issues are considered security issues.
@corinagum corinagum added area-docs Documentation required customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. needs-scope needs-scheduling needs-team-attention labels Oct 1, 2020
@corinagum corinagum self-assigned this Oct 1, 2020
@compulim compulim added this to the R11 milestone Oct 2, 2020
@compulim
Copy link
Contributor

compulim commented Oct 2, 2020

For example, one of the PoliCheck result can be found at, https://fuselabs.visualstudio.com/BotFramework-WebChat/_build/results?buildId=171404&view=artifacts&type=publishedArtifacts.

@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. and removed needs-scope labels Oct 5, 2020
@cwhitten cwhitten added p1 Painful if we don't fix, won't block releasing p0 Must Fix. Release-blocker and removed p1 Painful if we don't fix, won't block releasing labels Oct 14, 2020
@corinagum corinagum mentioned this issue Oct 16, 2020
Merged
9 tasks
@compulim compulim mentioned this issue Oct 29, 2020
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
area-docs Documentation required Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. p0 Must Fix. Release-blocker
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

Fix PoliCheck (security updates) corinagum/BotFramework-WebChat
3 participants
@cwhitten @compulim @corinagum