Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Update activity timestamp grouping to match visual UI #3616

Closed
corinagum opened this issue Nov 24, 2020 · 5 comments
Closed
Assignees
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label p1 Painful if we don't fix, won't block releasing
Milestone

Comments

@corinagum
Copy link
Contributor

(Filed internally from Web Chat customer)

Currently, AT will read every date/time after each activity, regardless of grouptimestamp style option

Version

4.11.0

Description

  • Currently on AT, each activity is read with the accompanying timestamp, regardless of the visual UI.
  • By default, the visual UI groups all uninterrupted activities from a single user with one timestamp.

Request:

  • Modify behavior to match visual UI
  • Note: this change will regroup incoming activities to be grouped with a single timestamp for AT. This will fix behavior when navigating the DOM tree. Expected behavior when navigating the DOM (iPhone: single-finger-right-swipe): each paragraph and activity is read separately, but there will be only one timestamp at the end of one group. In this case one group amounts to all uninterrupted activities from a single user.
  • However, during live reading, each incoming activity will always be accompanied by a timestamp and therefore may be read by VoiceOver before the next activity arrives and the regrouping is performed. Web Chat already has message rendering delays to avoid too many screenreader repeats due to these re-renders, but we can’t guarantee this change will prevent the date being read live before a new activity is rendered.
  • Regrouping should also be applied to 'Bot said', 'Bot attached' text
@corinagum corinagum added area-accessibility customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. feature-request Azure report label labels Nov 24, 2020
@corinagum
Copy link
Contributor Author

Currently being investigated by compuilim

@corinagum corinagum added this to the R12 milestone Jan 13, 2021
@corinagum corinagum added p1 Painful if we don't fix, won't block releasing and removed needs-team-attention labels Jan 13, 2021
@amal-khalaf
Copy link

Investigation Results:
once activity is marked as sent it is written to DOM as well as it Timestamp , only when the next activity arrive and mark as sent when the group timestamp logic kicks in. which could be milliseconds apart.
the technical limitation here is once a live region element is written to the DOM and marked with aria attribute to be logged
it is added to narration queue so even if we removed the element from the DOM later on it will still be announced.

Actions:
I discussed the issue and above limitation with Guy Barker and Ryan from accessibility team their input on this issue is the following:

  • given that the case here is a user getting more information not losing or hiding any ,
  • the recommendation is to add documentation that live activity will always have time stamp associated to them
  • this issue severity could be lowered and closed.

@corinagum
Copy link
Contributor Author

corinagum commented Feb 3, 2021

@amal-khalaf I mentioned in the email I sent that this will be closed, but would you prefer to make this P1 P2 and add that documentation for R12?

@cwhitten
Copy link
Member

cwhitten commented Feb 8, 2021

● useScrollTo.keepNewMessagesButton › should scroll and keep "New Messages" button

Unhandled exception from the test code on the page.

Error: Test code timed out while waiting for "New message button is shown".

  at http:/webchat2/__dist__/testharness.js:1:5036
  at _loop$ (__tests__/html/__jest__/createJobObservable.js:47:13)
  at tryCatch (node_modules/regenerator-runtime/runtime.js:63:40)
  at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:293:22)
  at Generator.next (node_modules/regenerator-runtime/runtime.js:118:21)
  at tryCatch (node_modules/regenerator-runtime/runtime.js:63:40)
  at maybeInvokeDelegate (node_modules/regenerator-runtime/runtime.js:356:18)
  at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:267:32)
  at Generator.next (node_modules/regenerator-runtime/runtime.js:118:21)
  at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)

@corinagum
Copy link
Contributor Author

Closing as complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

4 participants