Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria-pressed and aria-role is not properly set on AC submit buttons #3747

Closed
amal-khalaf opened this issue Feb 22, 2021 · 0 comments · Fixed by #3744
Closed

Aria-pressed and aria-role is not properly set on AC submit buttons #3747

amal-khalaf opened this issue Feb 22, 2021 · 0 comments · Fixed by #3744
Assignees
@amal-khalaf
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@amal-khalaf
Copy link

Version

v.4.12.0

Describe the bug

aria-pressed and aria-role is not properly set on AC submit buttons

Steps to reproduce

  1. Open
  2. open any webchat sample localhost:5000/samples/
  3. Input text 'card breakfast'
  4. Select any button 'xxx' in the AC and sumbit

Expected behavior

You should hear 'xxx' button pressed

Additional context

aria-pressed and role was set on the AC-container level
@amal-khalaf amal-khalaf added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Feb 22, 2021
@amal-khalaf amal-khalaf self-assigned this Feb 22, 2021
@compulim compulim removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Feb 22, 2021
@corinagum corinagum mentioned this issue Feb 22, 2021
Merged
10 tasks
@compulim compulim mentioned this issue Mar 2, 2021
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amal-khalaf amal-khalaf

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix aria-pressed for AC submit buttons amal-khalaf/BotFramework-WebChat
2 participants
@compulim @amal-khalaf