Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN bundle (UMD build) is broken due to bug in Webpack 5.89 #5155

Closed
compulim opened this issue May 2, 2024 · 0 comments · Fixed by #5156 · 4 remaining pull requests
Closed

CDN bundle (UMD build) is broken due to bug in Webpack 5.89 #5155

compulim opened this issue May 2, 2024 · 0 comments · Fixed by #5156 · 4 remaining pull requests
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented May 2, 2024

Is it an issue related to Adaptive Cards?

No

Is this an accessibility issue?

No

What version of Web Chat are you using?

Development build

Which distribution are you using Web Chat from?

Bundle (webchat.js)

Which hosting environment does this issue primarily affect?

Web apps

Which browsers and platforms do the issue happened?

Others or unrelated

Which area does this issue affect?

Others or unrelated

Which theme pack does this issue affect?

I did not test it on other theme packs

What is the public URL for the website?

No response

Please describe the bug

Webpack 5.84.1 has a bug that marked event-target-shim to be "unused pure superclass". We are on Webpack 5.89.0 and experiencing the bug.

Our recent ESM work emits minified code in our package tarball. And Webpack did not parse minified code properly. For example:

var ABC = class extends XYZ {}, abc = new ABC();

Webpack will re-emit it as following and marked the XYZ superclass as "unused pure":

var ABC = class extends (null && XYZ) {}, abc = new ABC();

We should bump to Webpack 5.91.0 to resolve the issue.

Do you see any errors in console log?

Uncaught TypeError: Super constructor null of anonymous class is not a constructor

How to reproduce the issue?

  1. Load UMD of botframework-webchat@4.17.0-main.20240501.533c151

What do you expect?

Web Chat loaded properly.

What actually happened?

An error saying "Super constructor null of anonymous class is not a constructor".

Do you have any screenshots or recordings to repro the issue?

image

image

Adaptive Card JSON

No response

Additional context

No response

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. and removed customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels May 2, 2024
@compulim compulim changed the title UMD build broken due to bug in Webpack 5.89 CDN bundle (UMD build) is broken due to bug in Webpack 5.89 May 2, 2024
This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment