fix: meeting scheduled date time response issue #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjitPadhi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue of not receiving the date and time of the next scheduled meeting by updating the kernel function's description to include details about upcoming meeting dates/times. It also includes a comprehensive update to the .dockerignore file for improved container builds.
- Updated the function decorator in chat_logic_handler.py to correct spelling and expand on meeting details.
- Added a detailed .dockerignore file to exclude unnecessary files from container builds.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/App/backend/chat_logic_handler.py | Updated the kernel_function description to fix a spelling error and clarify it now returns meeting details. |
| src/.dockerignore | Introduced an extensive ignore list to prevent inclusion of non-essential files in container builds. |
| return answer | ||
|
|
||
| @kernel_function(name="ChatWithSQLDatabase", description="Given a query about client assets, investements and meeting dates or times, get details from the database based on the provided question and client id") | ||
| @kernel_function(name="ChatWithSQLDatabase", description="Given a query about client assets, investments and meeting scheduled (including upcoming or next meeting dates/times), get details from the database based on the provided question and client id") |
There was a problem hiding this comment.
[nitpick] The updated description is clearer, but the phrasing with parentheses may be improved for readability. Consider streamlining the wording to ensure consistency with other function descriptions, for example, '... and next scheduled meeting date/time' could be a simpler alternative.
AjitPadhi-Microsoft
changed the title
Roopan-Microsoft
approved these changes
May 14, 2025
Roopan-Microsoft
added a commit
that referenced
this pull request
May 21, 2025
* Added .dockerignore file to exclude unnecessary files from Docker build context (#537) * fixed date time response issue (#542) * Update main.bicepparam * Update src/App/backend/chat_logic_handler.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/.dockerignore Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Prasanjeet-Microsoft <v-singhprasa@microsoft.com> Co-authored-by: AjitPadhi-Microsoft <v-padhiajit@microsoft.com> Co-authored-by: Abdul-Microsoft <v-amujeebta@microsoft.com> Co-authored-by: Harmanpreet Kaur <v-harmanpkau@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information