fix: improve Azure authentication messages in scripts #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harsh-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Roopan-Microsoft
approved these changes
Jun 30, 2025
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to Azure authentication handling across multiple scripts in the
infra/scriptsdirectory. The changes ensure consistent messaging and better structure for authentication logic. Additionally, minor adjustments were made to streamline logging during JSON processing.Improvements to Azure Authentication Logic:
infra/scripts/add_user_scripts/create_sql_user_and_role.sh: Moved the "Not authenticated with Azure" message to appear before the authentication attempt, ensuring clearer messaging flow. [1] [2]infra/scripts/copy_kb_files.sh: Adjusted the placement of the "Not authenticated with Azure" message for consistency with other scripts. [1] [2]infra/scripts/process_sample_data.sh: Added a new Azure authentication block, including support for both Managed Identity and Azure CLI authentication, ensuring the script can handle various environments.infra/scripts/run_create_index_scripts.sh: Updated the authentication messaging to align with the changes in other scripts. [1] [2]Logging Adjustments:
infra/scripts/add_user_scripts/create_sql_user_and_role.sh: Moved the "Processing JSON object" log message to the correct location within the loop for better clarity during execution.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information