Skip to content

Conversation

@Harsh-Microsoft
Copy link
Contributor

@Harsh-Microsoft Harsh-Microsoft commented Jul 10, 2025

Purpose

This pull request updates the deployment and test automation workflows in the .github/workflows directory to enhance flexibility, improve resource management, and streamline automation processes. The most significant changes include adding branch support for deployment triggers, using environment variables for resource capacities, refining deployment tagging, and removing redundant role assignments.

Deployment Workflow Enhancements (CAdeploy.yml):

  • Branch Trigger Updates: Added support for dev and demo branches in addition to main for triggering deployments.
  • Environment Variable Integration: Updated GPT_MIN_CAPACITY and TEXT_EMBEDDING_MIN_CAPACITY to use environment variables instead of hardcoded values for better configurability.
  • Improved Deployment Tagging: Refined the logic for image tagging by replacing the default tag with latest and updating the output variable to IMAGE_TAG.
  • Quota Check Notification Update: Enhanced the quota failure notification message to provide more context and clarity for the deployment team.
  • Simplified Role Assignments: Removed redundant role assignment commands and replaced them with streamlined post-deployment scripts for Cosmos DB access, file copying, and index creation.

Test Automation Workflow Updates (test_automation.yml):

  • Workflow Trigger Changes: Replaced push, schedule, and workflow_dispatch triggers with workflow_call for better modularity and reusability. Added support for optional email notification logic app URL as a secret.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

This comment was marked as outdated.

@Harsh-Microsoft Harsh-Microsoft requested a review from Copilot July 10, 2025 07:59

This comment was marked as outdated.

@Harsh-Microsoft Harsh-Microsoft requested a review from Copilot July 10, 2025 08:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test automation and deployment workflows to improve modularity, configurability, and resource management.

  • Replaces push/schedule/dispatch triggers in test automation with workflow_call, adding input parameters and an optional email notification secret
  • Adds dev/demo branch support, parameterizes resource capacities, refines image tagging logic, and consolidates post-deployment steps in CAdeploy.yml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test_automation.yml Swapped triggers for workflow_call, defined inputs and secrets
.github/workflows/CAdeploy.yml Added branches, env-var capacities, updated tagging, streamlined role assignments and scripts
Comments suppressed due to low confidence (3)

.github/workflows/CAdeploy.yml:56

  • Provide a default fallback or fail-fast check for GPT_MIN_CAPACITY and TEXT_EMBEDDING_MIN_CAPACITY to ensure they aren’t empty if the environment variables aren’t set.
          export GPT_MIN_CAPACITY="${{ env.GPT_MIN_CAPACITY }}"

.github/workflows/CAdeploy.yml:75

  • [nitpick] Consider simplifying and clarifying the notification body for readability and verify that the solution name matches internal naming conventions.
              "body": "<p>Dear Team,</p><p>We would like to inform you that the Build-your-own-copilot-Solution-Accelerator(Client Advisor) Deployment Automation process has encountered a quota issue. Hence, unable to proceed with the deployment.</p><p><a href=\"'${RUN_URL}'\">View run</a></p>"

.github/workflows/CAdeploy.yml:137

  • [nitpick] The fallback to 'latest' for unrecognized branches may mask unsupported branch deployments; consider logging a warning or explicitly failing when encountering unexpected branch names.
          else TAG="latest"; fi

@Roopan-Microsoft Roopan-Microsoft merged commit 0c662ff into main Jul 10, 2025
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants