Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop keeping track of destroyed node-to-node channels #2673

Closed
jumaffre opened this issue Jun 15, 2021 · 2 comments
Closed

Stop keeping track of destroyed node-to-node channels #2673

jumaffre opened this issue Jun 15, 2021 · 2 comments
Assignees
Milestone

Comments

@jumaffre
Copy link
Contributor

We currently keep track of destroyed node-to-node channels (i.e. replace the std::shared_ptr<Channel> with nullptr in the channels map, instead of simply deleting the NodeId key).

We should try to fix, considering what may potentially break in some end-to-end tests (e.g. code update, reconfiguration).

@achamayou
Copy link
Member

Link #2672

@achamayou achamayou added the 3.x label May 23, 2022
@shokouedamsr shokouedamsr added this to the 3.x milestone Jul 25, 2022
@achamayou achamayou added 4.x and removed 3.x labels Nov 16, 2022
@shokouedamsr shokouedamsr modified the milestones: 3.x, 4.x Dec 5, 2022
@shokouedamsr shokouedamsr added p1 and removed p2 labels Dec 5, 2022
@eddyashton eddyashton self-assigned this May 15, 2023
@eddyashton
Copy link
Member

This was done as part of #2801. In moving NodeToNodeChannelManager to its own file, we also removed the destroy_channel paths which filled the map with tombstone null pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants