You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently keep track of destroyed node-to-node channels (i.e. replace the std::shared_ptr<Channel> with nullptr in the channels map, instead of simply deleting the NodeId key).
We should try to fix, considering what may potentially break in some end-to-end tests (e.g. code update, reconfiguration).
The text was updated successfully, but these errors were encountered:
This was done as part of #2801. In moving NodeToNodeChannelManager to its own file, we also removed the destroy_channel paths which filled the map with tombstone null pointers.
We currently keep track of destroyed node-to-node channels (i.e. replace the
std::shared_ptr<Channel>
withnullptr
in the channels map, instead of simply deleting theNodeId
key).We should try to fix, considering what may potentially break in some end-to-end tests (e.g. code update, reconfiguration).
The text was updated successfully, but these errors were encountered: