Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The /recovery/members/{memberId}:recover endpoint in the 2023-06-01-preview API is unauthenticated #5821

Closed
achamayou opened this issue Nov 8, 2023 · 1 comment · Fixed by #5832
Closed

The /recovery/members/{memberId}:recover endpoint in the 2023-06-01-preview API is unauthenticated #5821

achamayou opened this issue Nov 8, 2023 · 1 comment · Fixed by #5832
Labels
bug

Comments

@achamayou
Copy link
Member

achamayou commented Nov 8, 2023 •
edited
Loading

Users submitting a COSE Sign1 payload get a JSON parsing error as a result.

The code should definitely at least support both, for consistency (all POSTs authenticated via signatures), and probably only authenticated access to avoid a potential denial of service by a malicious sender posting invalid shares.
@achamayou achamayou added the bug label Nov 8, 2023
@achamayou
Copy link
Member Author

https://github.com/Azure/azure-rest-api-specs/blob/main/specification/confidentialledger/Microsoft.ManagedCcf/examples/2023-06-01-preview/Shares_Submit.json suggests this was always intended to be authenticated and that the current behaviour is an oversight.

@achamayou achamayou mentioned this issue Nov 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Authenticate recovery share submission achamayou/CCF
1 participant
@achamayou