Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP frontend returns a JSON-RPC response regardless of payload type #843

Closed
eddyashton opened this issue Feb 14, 2020 · 1 comment
Closed

HTTP frontend returns a JSON-RPC response regardless of payload type #843

eddyashton opened this issue Feb 14, 2020 · 1 comment

Comments

@eddyashton
Copy link
Member

We do this because we're injecting the commit indices into the outer JSON object. Instead we should put these in headers in the HTTP response, and allow the payload to be determined entirely by the app (in practice in all of our current tests, this will be JSON or msgpack, to match the request payload/headers).
@eddyashton eddyashton mentioned this issue Feb 17, 2020
Merged
@eddyashton
Copy link
Member Author

Resolved by #921.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddyashton