Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Type mappings for structs should be marked with WindowsRuntimeTypeAttribute #144

Closed
jkoritzinsky opened this issue Apr 15, 2020 · 0 comments · Fixed by #146
Closed

Manual Type mappings for structs should be marked with WindowsRuntimeTypeAttribute #144

jkoritzinsky opened this issue Apr 15, 2020 · 0 comments · Fixed by #146
Labels
fixed Issue has been fixed in an upcoming or existing release

Comments

@jkoritzinsky
Copy link
Member

The structs we just added in #141 didn't get marked with the WinRT.WindowsRuntimeTypeAttribute attribute. As a result, some portions of the system will incorrectly recognize them as .NET types instead of Windows Runtime types. We should mark them as WinRT types to ensure they'r recognized correctly.
@Scottj1s Scottj1s mentioned this issue Apr 15, 2020
Merged
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

applied missing WindowsRuntimeTypeAttribute to mapped structs microsoft/CsWinRT
2 participants
@jkoritzinsky @angelazhangmsft