Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose whether to project Point, Rect, Size as double (current) or float (correct) #198

Closed
Scottj1s opened this issue Apr 23, 2020 · 1 comment · Fixed by #258
Closed

Choose whether to project Point, Rect, Size as double (current) or float (correct) #198

Scottj1s opened this issue Apr 23, 2020 · 1 comment · Fixed by #258
Assignees
@Scottj1s
Labels
fixed Issue has been fixed in an upcoming or existing release

Comments

@Scottj1s
Copy link
Member

The existing .NET geometry type projections use doubles on the interface, but floats as internal storage (blittable to the underlying WinRT structs, which also use floats). The resulting conversion errors are a problem for some developers. We can choose to keep the old incorrect behavior, or adopt correct but breaking behavior.

See these discussions for background:
#77
microsoft/microsoft-ui-xaml#2047
@Scottj1s Scottj1s mentioned this issue Apr 23, 2020
Closed
@Scottj1s Scottj1s mentioned this issue May 4, 2020
Merged
@Scottj1s
Copy link
Member Author

Scottj1s commented May 4, 2020

Holding, while confirming WinUI position...

@Scottj1s Scottj1s self-assigned this May 4, 2020
@Scottj1s Scottj1s mentioned this issue May 18, 2020
Closed
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottj1s Scottj1s

Labels
fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

flip geometry types from double to float, per community feedback microsoft/CsWinRT
2 participants
@Scottj1s @angelazhangmsft