Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#/WinRT doesn't properly incremental build #636

Closed
stevenbrix opened this issue Dec 11, 2020 · 1 comment · Fixed by #637
Closed

C#/WinRT doesn't properly incremental build #636

stevenbrix opened this issue Dec 11, 2020 · 1 comment · Fixed by #637
Assignees
Labels
bug Something isn't working fixed Issue has been fixed in an upcoming or existing release
Milestone

Comments

@stevenbrix
Copy link
Contributor

If I change an .idl file in my C++ project, when I do an incremental build, the C#/WinRT projection isn't updated. This is the opposite problem of #519.

Repro project: CS-Desktop2.zip

Repro steps:

  1. Do a full build
  2. In the RuntimeComponent1 project, change Class.idl to take a constructor which accepts an Int32:
    Class(Int32 prop);
  3. Do an incremental build

Expected results
Build fails, since call sites in C# code is using the default constructor, which no longer exists

Actual results
Build succeeds

@Scottj1s
Copy link
Member

Problem doesn't occur from command line (msbuild), so we likely need to add tlog entries for cswinrt.exe executions

@Scottj1s Scottj1s self-assigned this Dec 11, 2020
@manodasanW manodasanW added the bug Something isn't working label Dec 11, 2020
@manodasanW manodasanW added this to the Release 1.2.0 milestone Dec 11, 2020
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been fixed in an upcoming or existing release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants