Skip to content

Comments

[NPU] Add NPU to support hybrid engine#4831

Merged
mrwyattii merged 10 commits intodeepspeedai:masterfrom
CurryRice233:rlhf
Feb 1, 2024
Merged

[NPU] Add NPU to support hybrid engine#4831
mrwyattii merged 10 commits intodeepspeedai:masterfrom
CurryRice233:rlhf

Conversation

@CurryRice233
Copy link
Contributor

@CurryRice233 CurryRice233 commented Dec 18, 2023

Add NPU to support the hybrid engine, we tested it with the example on DeepSpeedExample and the results, average reward scores, were aligned with the GPU.

For works about NPU, see #4567

Co-authored-by: wangshuai09 <391746016@qq.com>
@CurryRice233
Copy link
Contributor Author

CurryRice233 commented Dec 22, 2023

@mrwyattii Hi, could you please help to retrigger the workflow and review this PR ?

@CurryRice233
Copy link
Contributor Author

@tjruwase @mrwyattii hi, would you please help to review this PR and add to merge queue? CI has passed.

@tjruwase
Copy link
Contributor

tjruwase commented Jan 4, 2024

@CurryRice233, thanks for this PR. Apologies for the delay. Most of the team are just returning from the holidays. We will review asap.

@CurryRice233
Copy link
Contributor Author

@tjruwase The CI failed. It seems that there is a problem with the CI server. Can you check it?

@loadams loadams removed the request for review from cmikeh2 January 10, 2024 22:49
@CurryRice233
Copy link
Contributor Author

@tjruwase @loadams CI passed again, can you help to review this PR and add to merge queue?

@tjruwase
Copy link
Contributor

@tjruwase @loadams CI passed again, can you help to review this PR and add to merge queue?

@CurryRice233, we will review this asap!

@CurryRice233
Copy link
Contributor Author

@mrwyattii Hi, can you add this PR to merge queue, thank you !

@mrwyattii mrwyattii added this pull request to the merge queue Feb 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@mrwyattii mrwyattii merged commit 88cca60 into deepspeedai:master Feb 1, 2024
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
Add NPU to support the hybrid engine, we tested it with the example on
[DeepSpeedExample](https://github.com/microsoft/DeepSpeedExamples/tree/master/applications/DeepSpeed-Chat/training/step3_rlhf_finetuning)
and the results, average reward scores, were aligned with the GPU.

For works about NPU, see
deepspeedai#4567

---------

Co-authored-by: jializheng <jializheng@huawei.com>
Co-authored-by: wangshuai09 <391746016@qq.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
Add NPU to support the hybrid engine, we tested it with the example on
[DeepSpeedExample](https://github.com/microsoft/DeepSpeedExamples/tree/master/applications/DeepSpeed-Chat/training/step3_rlhf_finetuning)
and the results, average reward scores, were aligned with the GPU.

For works about NPU, see
deepspeedai#4567

---------

Co-authored-by: jializheng <jializheng@huawei.com>
Co-authored-by: wangshuai09 <391746016@qq.com>
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants