Skip to content

deepspeed engine: fp16 support validation on init #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 2 commits into from
Dec 26, 2023
Merged

deepspeed engine: fp16 support validation on init #4843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd56d55
deepspeed engine: fp16 support validation on init
Dec 20, 2023
e53c801
Merge branch 'microsoft:master' into engine_runtime_fp16_validation
nelyahu Dec 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,9 @@ def _supported_optims(self):

# Validate configuration based on command line arguments
def _do_sanity_check(self):
if self.fp16_enabled() and not get_accelerator().is_fp16_supported():
raise ValueError("Type fp16 is not supported.")

expected_optim_types = self._supported_optims()
expected_optim_types += [type(None), Callable]
assert isinstance(self.client_optimizer, tuple(expected_optim_types)), \
Expand Down