Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test limitation: %D3DReflect only loads from prior stage stdout, preventing IR-based test #6271

Closed
tex3d opened this issue Feb 10, 2024 · 0 comments
Labels
bug Bug, regression, crash test Test issues or more test coverage needed

Comments

@tex3d
Copy link
Contributor

tex3d commented Feb 10, 2024

Description
In FileCheckerTest.cpp, %D3DReflect requires the use of %s argument, but does not load contents from the file. Instead, it loads from prior stage's stdout (Prior->StdOut). If you start from IR, there's no way to get your IR into the StdOut for the next stage, making it difficult or impossible to feed it to %D3DReflect. We should fix this handling so it accepts from prior stage's stdout (Prior->StdOut) only when %s is not supplied. Then when %s is supplied, use the file as the input instead.

A temporary workaround for this was added in #6207 and commented on here and here. This workaround will load the file if the output from the prior stage is empty, since otherwise empty input causes a crash anyway.

Steps to Reproduce

; RUN: %dxilver 1.6 | %D3DReflect %s | FileCheck %s -check-prefixes=RDAT,RDAT16
; followed by an IR based test

Fixing this will require an update of a bunch of tests that all use the form %D3DReflect %s to remove the %s.

Actual Behavior
Crash, or workaround in #6207 will make this work, but it's not selecting input based on whether %s is present like it should.

Environment

  • DXC version: any recent
  • Host Operating System: any
@tex3d tex3d added bug Bug, regression, crash needs-triage Awaiting triage labels Feb 10, 2024
@pow2clk pow2clk added test Test issues or more test coverage needed and removed needs-triage Awaiting triage labels Feb 13, 2024
@pow2clk pow2clk moved this to Done in HLSL Triage Feb 13, 2024
@damyanp damyanp closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash test Test issues or more test coverage needed
Projects
Archived in project
Development

No branches or pull requests

3 participants