-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Input-specific functions in IVariableLengthStruct #289
Comments
Also cc @mito-csod |
We could move out methods from |
Makes sense. We could introduce |
PR is out, will merge soon based on feedback if any. |
In #270, we added an additional method to
IVariableLengthStruct
:int GetLength<Input>(ref T t, ref Input input)
In addition, we already had this earlier:
int GetInitialLength<Input>(ref Input input)
With the moving of
Input
to client sessions (which is a huge improvement, btw), it is causing complications when users have sessions with different input types on the same FASTER store, as the above two functions cannot be typed specifically to a session.The proposal would be to instead provide these two methods via
ClientSession
(internally,FasterSession
) so that they may be customized per Input type.CC @marius-klimantavicius as you authored the above-referenced PR and are in the best position to comment/contribute on this.
The text was updated successfully, but these errors were encountered: