Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FasterLogSettings.LogCommitFile seems to be no longer used. #490

Closed
itn3000 opened this issue Jun 7, 2021 · 0 comments · Fixed by #494
Closed

FasterLogSettings.LogCommitFile seems to be no longer used. #490

itn3000 opened this issue Jun 7, 2021 · 0 comments · Fixed by #494

Comments

@itn3000
Copy link
Contributor

itn3000 commented Jun 7, 2021

Currently, FasterLogSettings.LogCommitFile is described in document as below(from FasterLog's github.io):

The file used to store log commit info, defaults to the log file name with a ‘.commit’ suffix. 
This is just a shortcut to setting LogCommitManager to new LocalLogCommitManager(LogCommitFile).

But actually, LogCommitFile is not used in new DeviceLogCommitCheckpointManager implementation ,
and user cannot set oldCommitManager = true. (see:

if (oldCommitManager)
{
logCommitManager = logSettings.LogCommitManager ??
new LocalLogCommitManager(logSettings.LogCommitFile ??
logSettings.LogDevice.FileName + ".commit");
}
else
{
logCommitManager = logSettings.LogCommitManager ??
new DeviceLogCommitCheckpointManager
(new LocalStorageNamedDeviceFactory(),
new DefaultCheckpointNamingScheme(
new FileInfo(logSettings.LogDevice.FileName).Directory.FullName));
}
)

So I think FasterLogSettings.LogCommitFile should be added Obsolete attribute or change FasterLog implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant