You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, FasterLogSettings.LogCommitFile is described in document as below(from FasterLog's github.io):
The file used to store log commit info, defaults to the log file name with a ‘.commit’ suffix.
This is just a shortcut to setting LogCommitManager to new LocalLogCommitManager(LogCommitFile).
But actually, LogCommitFile is not used in new DeviceLogCommitCheckpointManager implementation ,
and user cannot set oldCommitManager = true. (see:
Currently,
FasterLogSettings.LogCommitFile
is described in document as below(from FasterLog's github.io):But actually, LogCommitFile is not used in new DeviceLogCommitCheckpointManager implementation ,
and user cannot set
oldCommitManager = true
. (see:FASTER/cs/src/core/Index/FasterLog/FasterLog.cs
Lines 137 to 150 in a31b52b
So I think FasterLogSettings.LogCommitFile should be added
Obsolete
attribute or change FasterLog implementation.The text was updated successfully, but these errors were encountered: