Remove nullable usage. Other updates.

Author: jimmyca15

examples/EvaluationDataToApplicationInsights/HttpContextTargetingContextAccessor.cs

@@ -31,11 +31,11 @@ public ValueTask<TargetingContext> GetContextAsync()
 
             string username = httpContext.Request.Cookies["username"];
 
-            List<string> groups = new List<string>();
+            var groups = new List<string>();
 
             //
-            // Build targeting context based off user info
-            TargetingContext targetingContext = new TargetingContext
+            // Build targeting context based on user info
+            var targetingContext = new TargetingContext
             {
                 UserId = username,
                 Groups = groups

examples/EvaluationDataToApplicationInsights/Pages/Error.cshtml.cs

@@ -8,7 +8,7 @@ namespace EvaluationDataToApplicationInsights.Pages
     [IgnoreAntiforgeryToken]
     public class ErrorModel : PageModel
     {
-        public string? RequestId { get; set; }
+        public string RequestId { get; set; }
 
         public bool ShowRequestId => !string.IsNullOrEmpty(RequestId);
 

examples/EvaluationDataToApplicationInsights/Pages/Index.cshtml.cs

@@ -10,7 +10,7 @@ public class IndexModel : PageModel
         private readonly IVariantFeatureManager _featureManager;
         private readonly TelemetryClient _telemetry;
 
-        public string? Username { get; set; }
+        public string Username { get; set; }
 
         public IndexModel(
             IVariantFeatureManager featureManager,
@@ -31,7 +31,6 @@ public async Task<IActionResult> OnGet()
 
             //
             // Use application's feature manager to get assigned variant for current user
-            //
             Variant variant = await _featureManager
                 .GetVariantAsync("ImageRating", HttpContext.RequestAborted);
 

examples/EvaluationDataToApplicationInsights/Program.cs

@@ -9,16 +9,6 @@
 
 var builder = WebApplication.CreateBuilder(args);
 
-//
-// Use Azure App Configuration as an application configuration provider
-//
-builder
-    .Configuration
-    .AddAzureAppConfiguration((options) =>
-    {
-        options.Connect(builder.Configuration["AzureAppConfigurationConnectionString"]);
-    });
-
 //
 // What a web app using app insights looks like
 //

examples/EvaluationDataToApplicationInsights/README.md

@@ -21,7 +21,7 @@ These logs show what would be emitted to a connected Application Insights resour
 
 ## Connecting to Application Insights
 
-To flow these events to Application Insights, [setup a new Application Insights resource in Azure](https://learn.microsoft.com/en-us/azure/azure-monitor/app/create-workspace-resource). Once setup, from `Overview` copy the `Connection String` and place it in `appsettings.json` at ApplicationInsights > ConnectionString. After restarting the app, events should now flow to Application Insights.
+To flow these events to Application Insights, [setup a new Application Insights resource in Azure](https://learn.microsoft.com/en-us/azure/azure-monitor/app/create-workspace-resource). Once setup, from `Overview` copy the `Connection String` and place it in `appsettings.json` at ApplicationInsights > ConnectionString. After restarting the app, events should now flow to Application Insights. This [document](https://learn.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core?tabs=netcorenew%2Cnetcore6#enable-application-insights-server-side-telemetry-no-visual-studio) provides more details on connecting a .NET application to Application Insights.
 
 ## About the App
 This app uses [Application Insights for ASP.NET Core](https://learn.microsoft.com/en-us/azure/azure-monitor/app/asp-net-core?tabs=netcorenew%2Cnetcore6). This means there is an App Insights SDK in the C# code and a separate App Insights SDK the Javascript. Lets cover what they're doing:
@@ -69,7 +69,7 @@ Sample steps to try out the app:
 
 1. Run the app. When the app is first started a User Id and Session Id will be generated. The username cookie will be set to a random integer, and the ai_user and ai_session cookies will be expired.
 1. When the page is loaded, the "ImageRating" feature is evaluated which [defines three variants](./appsettings.json). Events can be seen in the Output window. (There may be a small delay as events are batched)
-1. Select a rating for the loaded image and click vote. A 'Vote' event will be emitted.
+1. Select a rating for the loaded image and click vote. A "Vote" event will be emitted.
 1. Go to Checkout and click "Check Out", which emits a custom event and a custom metric. This event and metric will be shown in the logs as well.
 1. If connected to Application Insights, head to the resource in the portal. Events and metrics will be there as well. 	
     1. Try going to Logs > New Query and run the query "customEvents". This should show the custom events emitted.

examples/EvaluationDataToApplicationInsights/Telemetry/MyTelemetryInitializer.cs

@@ -17,14 +17,14 @@ public MyTelemetryInitializer(IHttpContextAccessor httpContextAccessor)
 
         public void Initialize(ITelemetry telemetry)
         {
-            HttpContext? httpContext = _httpContextAccessor.HttpContext;
+            HttpContext httpContext = _httpContextAccessor.HttpContext;
 
             if (httpContext == null)
             {
                 return;
             }
 
-            string? username = httpContext.Request.Cookies["username"];
+            string username = httpContext.Request.Cookies["username"];
 
             if (username != null)
             {

examples/EvaluationDataToApplicationInsights/appsettings.json

@@ -7,6 +7,7 @@
     },
     "AllowedHosts": "*",
     "ApplicationInsights": {
+        "ConnectionString": "<connection-string>"
     },
     "FeatureManagement": {
         "ImageRating": {