Skip to content

Commit 16e4405

Browse files
remove configuration reference from variant definition
1 parent 91b7a2d commit 16e4405

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

src/featureManager.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,6 @@ export class FeatureManager implements IFeatureManager {
167167
// TODO: send telemetry for variant assignment reason in the future.
168168
console.log(`Variant assignment for feature ${featureName}: ${variantDef?.name ?? "default"} (${reason})`);
169169

170-
if (variantDef?.configuration_reference !== undefined) {
171-
console.warn("Configuration reference is not supported yet.");
172-
}
173-
174170
result.variant = variantDef !== undefined ? new Variant(variantDef.name, variantDef.configuration_value) : undefined;
175171
result.variantAssignmentReason = reason;
176172

src/model.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,6 @@ export interface VariantDefinition {
7878
* The configuration value for this feature variant.
7979
*/
8080
configuration_value?: unknown;
81-
/**
82-
* The path to a configuration section used as the configuration value for this feature variant.
83-
*/
84-
configuration_reference?: string;
8581
/**
8682
* Overrides the enabled state of the feature if the given variant is assigned. Does not override the state if value is None.
8783
*/

test/sampleFeatureFlags.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ export const featureFlagsConfigurationObject = {
208208
"variants": [
209209
{
210210
"name": "Big",
211-
"configuration_reference": "ShoppingCart:Big",
212211
"status_override": "Disabled"
213212
}
214213
],
@@ -231,8 +230,7 @@ export const featureFlagsConfigurationObject = {
231230
"enabled": true,
232231
"variants": [
233232
{
234-
"name": "Big",
235-
"configuration_reference": "ShoppingCart:Big"
233+
"name": "Big"
236234
}
237235
],
238236
"allocation": {
@@ -254,8 +252,7 @@ export const featureFlagsConfigurationObject = {
254252
"enabled": false,
255253
"variants": [
256254
{
257-
"name": "Big",
258-
"configuration_reference": "ShoppingCart:Big"
255+
"name": "Big"
259256
}
260257
],
261258
"allocation": {
@@ -415,8 +412,7 @@ export const featureFlagsConfigurationObject = {
415412
"variants": [
416413
{
417414
"name": "Small",
418-
"configuration_value": "600px",
419-
"configuration_reference": "ShoppingCart:Small"
415+
"configuration_value": "600px"
420416
}
421417
],
422418
"allocation": {

0 commit comments

Comments
 (0)