Merge branch 'main' into zhiyuanliang/add-basic-example

Author: zhiyuanliang-ms

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@microsoft/feature-management",
-  "version": "1.0.0-preview",
+  "version": "1.0.0",
   "description": "Feature Management is a library for enabling/disabling features at runtime. Developers can use feature flags in simple use cases like conditional statement to more advanced scenarios like conditionally adding routes.",
   "main": "./dist/commonjs/index.js",
   "module": "./dist/esm/index.js",
@@ -18,7 +18,7 @@
     "dev": "rollup --config --watch",
     "lint": "eslint src/ test/ --ignore-pattern test/browser/testcases.js",
     "fix-lint": "eslint src/ test/ --fix --ignore-pattern test/browser/testcases.js",
-    "test": "mocha out/test/*.test.{js,cjs,mjs} --parallel",
+    "test": "mocha out/*.test.{js,cjs,mjs} --parallel",
     "test-browser": "npx playwright install chromium && npx playwright test"
   },
   "repository": {
@@ -42,7 +42,7 @@
     "eslint": "^8.56.0",
     "mocha": "^10.2.0",
     "rimraf": "^5.0.5",
-    "rollup": "^4.9.4",
+    "rollup": "^4.22.4",
     "rollup-plugin-dts": "^6.1.0",
     "tslib": "^2.6.2",
     "typescript": "^5.3.3"

package.json

@@ -28,7 +28,7 @@ export class ConfigurationMapFeatureFlagProvider implements IFeatureFlagProvider
     }
     async getFeatureFlag(featureName: string): Promise<FeatureFlag | undefined> {
         const featureConfig = this.#configuration.get<FeatureManagementConfiguration>(FEATURE_MANAGEMENT_KEY);
-        return featureConfig?.[FEATURE_FLAGS_KEY]?.find((feature) => feature.id === featureName);
+        return featureConfig?.[FEATURE_FLAGS_KEY]?.findLast((feature) => feature.id === featureName);
     }
 
     async getFeatureFlags(): Promise<FeatureFlag[]> {
@@ -49,7 +49,7 @@ export class ConfigurationObjectFeatureFlagProvider implements IFeatureFlagProvi
 
     async getFeatureFlag(featureName: string): Promise<FeatureFlag | undefined> {
         const featureFlags = this.#configuration[FEATURE_MANAGEMENT_KEY]?.[FEATURE_FLAGS_KEY];
-        return featureFlags?.find((feature: FeatureFlag) => feature.id === featureName);
+        return featureFlags?.findLast((feature: FeatureFlag) => feature.id === featureName);
     }
 
     async getFeatureFlags(): Promise<FeatureFlag[]> {

src/featureProvider.ts

@@ -4,3 +4,4 @@
 export { FeatureManager } from "./featureManager.js";
 export { ConfigurationMapFeatureFlagProvider, ConfigurationObjectFeatureFlagProvider, IFeatureFlagProvider } from "./featureProvider.js";
 export { IFeatureFilter } from "./filter/FeatureFilter.js";
+export { VERSION } from "./version.js";

src/index.ts

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation.
-// Licensed under the MIT license.
-
-export * from "../src/index.js";
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+export const VERSION = "1.0.0";

test/exportedApi.ts renamed to src/version.ts

@@ -7,16 +7,15 @@ test("Testcase can pass in browser environment", async ({ page }) => {
   const filePath = path.join(__dirname, "index.html");
 
   let hasPageError = false;
-
   page.on("pageerror", (err) => {
     hasPageError = true;
     console.log(`Page Error: ${err.message}`);
   });
 
   await page.goto(`file:${filePath}`);
+  await page.waitForTimeout(10000);
 
   const failures = await page.evaluate(() => (window as any).mochaFailures);
-
   chai.expect(failures).to.equal(0);
   chai.expect(hasPageError).to.be.false;
 });

test/browser/browser.test.ts

@@ -19,7 +19,7 @@
     <script src="../../dist/umd/index.js"></script>
     <script src="./testcases.js"></script>
     <script class="mocha-exec">
-      mocha.run(function (failures) {
+      mocha.run(failures => {
         window.mochaFailures = failures;
       });
     </script>