-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IContainerRuntime*.get*DataStoreRuntime: Supply optional AbortSignal for cases where we wait #1192
Labels
Milestone
Comments
vladsud
changed the title
IHostRuntime.getComponentRuntime Replace optional wait, with optional AbortSignal
IContainerRuntime*.get*DataStoreRuntime: Replace optional wait, with optional AbortSignal
Feb 26, 2021
vladsud
changed the title
IContainerRuntime*.get*DataStoreRuntime: Replace optional wait, with optional AbortSignal
IContainerRuntime*.get*DataStoreRuntime: Supply optional AbortSignal for cases where we wait
Feb 26, 2021
I do not think it's replacement, it's addition. I.e. if we have to wait (or allow waiting), then we have to allow cancelation. |
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thinking about using AbortSignal for loader( #1191), and possibly adding to request.
Changing wait to AbortSignal would allow us to delegate the wait policy (timeout, etc). I'm thinking undefined AbortSignal would be equivalent to no wait.
The text was updated successfully, but these errors were encountered: