Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IContainerRuntime*.get*DataStoreRuntime: Supply optional AbortSignal for cases where we wait #1192

Closed
anthony-murphy opened this issue Feb 6, 2020 · 2 comments
Labels
Milestone

Comments

@anthony-murphy
Copy link
Contributor

Thinking about using AbortSignal for loader( #1191), and possibly adding to request.

Changing wait to AbortSignal would allow us to delegate the wait policy (timeout, etc). I'm thinking undefined AbortSignal would be equivalent to no wait.

@anthony-murphy anthony-murphy added the area: runtime Runtime related issues label Feb 7, 2020
@curtisman curtisman added this to the Next 2020 milestone Feb 10, 2020
@curtisman curtisman added the api label Oct 8, 2020
@vladsud vladsud changed the title IHostRuntime.getComponentRuntime Replace optional wait, with optional AbortSignal IContainerRuntime*.get*DataStoreRuntime: Replace optional wait, with optional AbortSignal Feb 26, 2021
@vladsud vladsud changed the title IContainerRuntime*.get*DataStoreRuntime: Replace optional wait, with optional AbortSignal IContainerRuntime*.get*DataStoreRuntime: Supply optional AbortSignal for cases where we wait Feb 26, 2021
@vladsud
Copy link
Contributor

vladsud commented Feb 26, 2021

I do not think it's replacement, it's addition. I.e. if we have to wait (or allow waiting), then we have to allow cancelation.
So changing title to reflect that.

@ghost
Copy link

ghost commented Aug 26, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

This was referenced Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants