-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Copy APIs out of common-definitions and remove dependencies #16638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0381e03
to
a38027c
Compare
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output
|
jatgarg
pushed a commit
to jatgarg/FluidFramework-1
that referenced
this pull request
Aug 18, 2023
…microsoft#16638) This PR deprecates the following types and interfaces from the common-definitions package: - interface IErrorEvent - interface IErrorEvent - interface IEvent - interface IEventProvider - type ExtendEventProvider - type IEventThisPlaceHolder - type IEventTransformer - type ReplaceIEventThisPlaceHolder The code has been copied into the core-interfaces package for client use. - All client package uses have been updated to use the core-interfaces implementation instead of common-definitions. - There are no longer any client dependencies on common-definitions. - **However,** there are still _server_ dependencies on common-definitions. It's not clear where the event-related APIs should live for server, so server continues to use the now-deprecated versions from common-definitions. - Also, protocol-definitions still imports and uses IErrorEvent and IEventProvider from common-definitions. I left those uses in place rather than copying the APIs into protocol-definitions.
vladsud
added a commit
that referenced
this pull request
Mar 12, 2024
See #16638 for example of prior work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: sharedstring
area: dds: tree
area: dds
Issues related to distributed data structures
area: dev experience
Improving the experience of devs building on top of fluid
area: driver
Driver related issues
area: examples
Changes that focus on our examples
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
area: loader
Loader related issues
area: odsp-driver
area: runtime
Runtime related issues
area: tests
Tests to add, test infrastructure improvements, etc
base: main
PRs targeted against main branch
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the following types and interfaces from the common-definitions package:
The code has been copied into the core-interfaces package for client use.