Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish server container images with semver #1708

Closed
kurtb opened this issue Apr 3, 2020 · 3 comments · Fixed by #3545
Closed

Publish server container images with semver #1708

kurtb opened this issue Apr 3, 2020 · 3 comments · Fixed by #3545
Labels
area: server Server related issues (routerlicious)

Comments

@kurtb
Copy link
Contributor

kurtb commented Apr 3, 2020

Feature

Is your feature request related to a problem? Please describe.
Docker doesn't check if tags have changed when running. This makes using "latest" problematic since you likely aren't actually on the latest.

Describe the solution you'd like
Similar to our NPM packages we should publish our docker images with a semver. and also update the ranges during publish. This is the common practice on Docker Hub.

For instance - if we just published routerlicoius at 1.2.3

We'd update routerlicoius:1, routerlicious:1.2, and routerlcious:1.2.3

The containers themselves would follow the semver as far as breaking changes go.

Then in our base docker-compose files we could reference either the major or major/minor pair. And rev this whenever a new service version is available.

@ghost ghost added the triage label Apr 3, 2020
@curtisman curtisman added the area: server Server related issues (routerlicious) label Apr 4, 2020
@curtisman curtisman added this to the Next 2020 milestone Apr 4, 2020
@curtisman curtisman removed the triage label Apr 4, 2020
@vladsud
Copy link
Contributor

vladsud commented May 28, 2021

@tanviraumi , @anthony-murphy , can you please triage? We either need a plan to make it happen or punt - no need to keep old issues around.

@tanviraumi
Copy link
Contributor

@curtisman I believe some of this already happens today. We do publish images with build numbers. Although we may not patch older versions?

@curtisman
Copy link
Member

Correct. We are tagging images with version number and latest.
But I didn't follow the recommendation above for the floating tag for major an major.minor.
We can probably close this for now unless there is a demand for it.

@danielroney danielroney removed this from the Next milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: server Server related issues (routerlicious)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants