Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate IRootDataObjectFactory #18565

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Deprecate IRootDataObjectFactory #18565

merged 2 commits into from
Dec 1, 2023

Conversation

kian-thompson
Copy link
Contributor

Upcoming Changes

Deprecated IRootDataObjectFactory

The IRootDataObjectFactory interface has been deprecated and will be removed in a future major release. Please remove all usage of it.

@kian-thompson kian-thompson requested review from a team as code owners November 30, 2023 23:14
@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct public api change Changes to a public API base: main PRs targeted against main branch labels Nov 30, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 30, 2023 •
edited
Loading

⯅ @fluid-example/bundle-size-tests: +14 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 450.83 KB 450.83 KB ⯅ +2 Bytes
connectionState.js 680 Bytes 680 Bytes ■ No change
containerRuntime.js 241.14 KB 241.14 KB ■ No change
loader.js 167.41 KB 167.41 KB ⯅ +2 Bytes
map.js 48.05 KB 48.05 KB ⯅ +2 Bytes
matrix.js 141.84 KB 141.84 KB ⯅ +2 Bytes
odspDriver.js 90.35 KB 90.36 KB ⯅ +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB ⯅ +2 Bytes
sharedString.js 162.77 KB 162.77 KB ■ No change
sharedTree2.js 289.21 KB 289.21 KB ■ No change
Total Size 1.75 MB 1.75 MB ⯅ +14 Bytes

Baseline commit: 784f8b6

Generated by 🚫 dangerJS against 6870b18

@kian-thompson kian-thompson merged commit 030ab7a into microsoft:main Dec 1, 2023
24 checks passed
@kian-thompson kian-thompson deleted the deprecate-IRootDataObjectFactory branch December 1, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agarwal-navin agarwal-navin agarwal-navin approved these changes

@ChumpChief ChumpChief ChumpChief approved these changes

@markfields markfields Awaiting requested review from markfields

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kian-thompson @msfluid-bot @ChumpChief @agarwal-navin