id-compressor: Remove deprecated compressor types from runtime definitions #19031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
Josmithr
added
the
breaking change
github-actions
bot
removed
the
breaking change
Josmithr
requested changes
Jan 3, 2024
Josmithr
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Please add a changeset doc noting the removed APIs, since this is breaking.
Also nits:
- It might be worth splitting this into 2 PRs: one that updates all of the imports to use the new package, and a second one that removes the deprecated APIs.
- I always recommend adding a link to the PR(s) that marked the APIs as deprecated in the description of the PR that removes them (to leave a helpful paper trail).
|
(sorry, didn't mean to leave 2 separate reviews... was trying to edit the existing one...) |
⯆ @fluid-example/bundle-size-tests: -551 Bytes
Baseline commit: d45a11d |
taylorsw04
changed the title
Josmithr
approved these changes
Jan 3, 2024
RishhiB
pushed a commit
to RishhiB/FluidFramework-1
that referenced
this pull request
Jan 3, 2024
…tions (microsoft#19031) ## Description This removes re-exported/deprecated compressor types from the runtime definitions public API. They were moved to the id-compressor package earlier. ## Breaking Changes The removed APIs were technically public but are very unlikely to ever have been used. They were moved to a publicly available package in microsoft#18749.
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 12, 2024
…tions (#19031) This removes re-exported/deprecated compressor types from the runtime definitions public API. They were moved to the id-compressor package earlier. The removed APIs were technically public but are very unlikely to ever have been used. They were moved to a publicly available package in
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
…tions (#19031) This removes re-exported/deprecated compressor types from the runtime definitions public API. They were moved to the id-compressor package earlier. The removed APIs were technically public but are very unlikely to ever have been used. They were moved to a publicly available package in
sonalideshpandemsft
pushed a commit
that referenced
this pull request
Apr 15, 2024
…tions (#19031) ## Description This removes re-exported/deprecated compressor types from the runtime definitions public API. They were moved to the id-compressor package earlier. ## Breaking Changes The removed APIs were technically public but are very unlikely to ever have been used. They were moved to a publicly available package in #18749.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes re-exported/deprecated compressor types from the runtime definitions public API. They were moved to the id-compressor package earlier.
Breaking Changes
The removed APIs were technically public but are very unlikely to ever have been used. They were moved to a publicly available package in #18749.