Promises in DDS's that resolve when an op is ack'd should reject if ack can't be received

[markfields]

General case for #1420. See PR #2066 for how to fix - use this.newAckBasedPromise instead of new Promise if the Promise should be rejected if we know the ack won't come in, e.g. on ComponentRuntime dispose.

It might be interesting to look into writing a custom eslint rule for this? The rule would enforce that new Promise isn't used in a class extending SharedObject. Might be too heavy-handed, but want to look into it.

[ghost]

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

[markfields]

I think this can go away. I believe the approach in the linked PR turned out to be incorrect anyway.

[markfields]

FYI @vladsud, in case you think there's something here (you just labeled it for 1.0 consideration)